VTAdmin users that can create shards can deny access to other functions
Impact
Users can either intentionally or inadvertently create a shard containing / characters from VTAdmin such that from that point on, anyone who tries to create a new shard from VTAdmin will receive an error.
Attempting to view the keyspace(s) will also no longer work.
Creating a shard using vtctldclient does not have the same problem because the CLI validates the input correctly.
Patches
v16.0.2, corresponding to [0.16.2 on pkg.go.dev](https://pkg.go.dev/vitess.io/vitess@v0.16.2)
Workarounds
- Always use
vtctldclientto create shards, instead of using VTAdmin - Disable creating shards from VTAdmin using RBAC
- Delete the topology record for the offending shard using the client for your topology server. For example, if you created a shard called
a/bin keyspacecommerce, and you are running etcd, it can be deleted by doing something like
`
% etcdctl --endpoints "http://${ETCD_SERVER}" del /vitess/global/keyspaces/commerce/shards/a/b/Shard
`
References
https://github.com/vitessio/vitess/issues/12842
Found during a security audit sponsored by the [CNCF](https://cncf.io) and facilitated by [OSTIF](https://ostif.org).
Affected versions
| Package | Affected | Fixed in |
|---|---|---|
| vitess.io/vitess Go | < 0.16.2 | 0.16.2 |
Details and references
- CVSS 3.1
- CVSS:3.1/AV:N/AC:L/PR:H/UI:N/S:C/C:N/I:N/A:L
- Severity from
- GitHub (reviewed advisory)
- Weakness
- CWE-20, CWE-703
- Also known as
- CVE-2023-29195
- github.com/vitessio/vitess/security/advisories/GHSA-pqj7-jx24-wj7w
- nvd.nist.gov/vuln/detail/CVE-2023-29195
- github.com/vitessio/vitess/issues/12842
- github.com/vitessio/vitess/pull/12843
- github.com/vitessio/vitess/commit/9dcbd7de3180f47e94f54989fb5c66daea00c920
- github.com/vitessio/vitess
- github.com/vitessio/vitess/releases/tag/v16.0.2
- pkg.go.dev/vitess.io/vitess@v0.16.2