Advisoriesby IbisTensorFlow vulnerable to assertion fail on MLIR empty edge names
Impact
When [mlir::tfg::ConvertGenericFunctionToFunctionDef](https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/ir/importexport/functiondef_import.cc) is given empty function attributes, it crashes.
```cpp
// We pre-allocate the array of operands and populate it using the
// output_name_to_position and control_output_to_position populated
// previously.
SmallVector<Value> ret_vals(func.ret_size() + func.control_ret_size(),
Value());
for (const auto& ret_val : func.ret()) {
auto position = output_name_to_position.find(ret_val.first);
if (position == output_name_to_position.end())
return InvalidArgument(
"Can't import function, returned value references unknown output "
"argument ",
ret_val.first);
ret_vals[position->second] =
value_manager.GetValueOrCreatePlaceholder(ret_val.second);
}
for (const auto& ret_val : func.control_ret()) {
auto position = control_output_to_position.find(ret_val.first);
if (position == control_output_to_position.end())
return InvalidArgument(
"Can't import function, returned value references unknown output "
"argument ",
ret_val.first);
Value result = value_manager.GetValueOrCreatePlaceholder(
(Twine("^") + ret_val.second).str());
`
ret_val.second cannot be empty. Neither can input.
```cpp
// Process every node...
Affected versions
| Package | Affected | Fixed in |
|---|---|---|
| tensorflow PyPI | < 2.7.2 | 2.7.2 |
| >= 2.8.0, < 2.8.1 | 2.8.1 | |
| >= 2.9.0, < 2.9.1 | 2.9.1 |
Details and references
### Impact When [`mlir::tfg::ConvertGenericFunctionToFunctionDef`](https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/ir/importexport/functiondef_import.cc) is given empty function attributes, it crashes. ```cpp // We pre-allocate the array of operands and populate it using the // `output_name_to_position` and `control_output_to_position` populated // previously. SmallVector<Value> ret_vals(func.ret_size() + func.control_ret_size(), Value()); for (const auto& ret_val : func.ret()) { auto position = output_name_to_position.find(ret_val.first); if (position == output_name_to_position.end()) return InvalidArgument( "Can't import function, returned value references unknown output " "argument ", ret_val.first); ret_vals[position->second] = value_manager.GetValueOrCreatePlaceholder(ret_val.second); } for (const auto& ret_val : func.control_ret()) { auto position = control_output_to_position.find(ret_val.first); if (position == control_output_to_position.end()) return InvalidArgument( "Can't import function, returned value references unknown output " "argument ", ret_val.first); Value result = value_manager.GetValueOrCreatePlaceholder( (Twine("^") + ret_val.second).str()); ``` `ret_val.second` cannot be empty. Neither can `input`. ```cpp // Process every node and create a matching MLIR operation for (const NodeDef& node : nodes) { if (node.op().empty()) return InvalidArgument("empty op type"); OperationState state(unknown_loc, absl::StrCat("tfg.", node.op())); // Fetch the inputs, creating placeholder if an input hasn't been visited. for (const std::string& input : node.input()) state.operands.push_back( value_manager.GetValueOrCreatePlaceholder(input)); ``` ### Patches We have patched the issue in GitHub commit [ad069af92392efee1418c48ff561fd3070a03d7b](https://github.com/tensorflow/tensorflow/commit/ad069af92392efee1418c48ff561fd3070a03d7b). The fix will be included in TensorFlow 2.10.0. We will also cherrypick this commit on TensorFlow 2.9.1, TensorFlow 2.8.1, and TensorFlow 2.7.2, as these are also affected and still in supported range. ### For more information Please consult [our security guide](https://github.com/tensorflow/tensorflow/blob/master/SECURITY.md) for more information regarding the security model and how to contact us with issues and questions.
- CVSS 3.1
- CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:N/I:N/A:H
- Severity from
- GitHub (reviewed advisory)
- Weakness
- CWE-617
- Also known as
- BIT-tensorflow-2022-36012, CVE-2022-36012, PYSEC-2026-1015, PYSEC-2026-3210, PYSEC-2026-3347
- github.com/tensorflow/tensorflow/security/advisories/GHSA-jvhc-5hhr-w3v5
- nvd.nist.gov/vuln/detail/CVE-2022-36012
- github.com/tensorflow/tensorflow/commit/ad069af92392efee1418c48ff561fd3070a03d7b
- github.com/tensorflow/tensorflow
- github.com/tensorflow/tensorflow/blob/master/tensorflow/core/ir/importexport/functiondef_import.cc
- github.com/tensorflow/tensorflow/releases/tag/v2.10.0
More TensorFlow advisories
All TensorFlow
TensorFlow vulnerable to `CHECK` fail in `Save` and `SaveSlices`CVE-2022-35983fixed in 2.7.2 +2TensorFlow vulnerable to `CHECK` fail in `ParameterizedTruncatedNormal`CVE-2022-35984fixed in 2.7.2 +2TensorFlow vulnerable to `CHECK` fail in `LRNGrad`CVE-2022-35985fixed in 2.7.2 +2TensorFlow vulnerable to segfault in `RaggedBincount`CVE-2022-35986fixed in 2.7.2 +2TensorFlow vulnerable to `CHECK` fail in `tf.linalg.matrix_rank`CVE-2022-35988fixed in 2.7.2 +2TensorFlow vulnerable to `CHECK` fail in `MaxPool`CVE-2022-35989fixed in 2.7.2 +2