Division by zero in TFLite's implementation of hashtable lookup
Impact
The TFLite implementation of hashtable lookup is [vulnerable to a division by zero error](https://github.com/tensorflow/tensorflow/blob/1a8e885b864c818198a5b2c0cbbeca5a1e833bc8/tensorflow/lite/kernels/hashtable_lookup.cc#L114-L115):
```cc
const int num_rows = SizeOfDimension(value, 0);
const int row_bytes = value->bytes / num_rows;
`
An attacker can craft a model such that values's first dimension would be 0.
Patches
We have patched the issue in GitHub commit [5117e0851348065ed59c991562c0ec80d9193db2](https://github.com/tensorflow/tensorflow/commit/5117e0851348065ed59c991562c0ec80d9193db2).
The fix will be included in TensorFlow 2.5.0. We will also cherrypick this commit on TensorFlow 2.4.2, TensorFlow 2.3.3, TensorFlow 2.2.3 and TensorFlow 2.1.4, as these are also affected and still in supported range.
For more information
Please consult [our security guide](https://github.com/tensorflow/tensorflow/blob/master/SECURITY.md) for more information regarding the security model and how to contact us with issues and questions.
Attribution
This vulnerability has been reported by members of the Aivul Team from Qihoo 360.
Affected versions
| Package | Affected | Fixed in |
|---|---|---|
| tensorflow PyPI | < 2.1.4 | 2.1.4 |
| >= 2.2.0, < 2.2.3 | 2.2.3 | |
| >= 2.3.0, < 2.3.3 | 2.3.3 | |
| >= 2.4.0, < 2.4.2 | 2.4.2 |
Details and references
- CVSS 3.1
- CVSS:3.1/AV:L/AC:H/PR:L/UI:N/S:U/C:N/I:N/A:L
- Severity from
- GitHub (reviewed advisory)
- Weakness
- CWE-369
- Also known as
- BIT-tensorflow-2021-29604, CVE-2021-29604, PYSEC-2021-241, PYSEC-2021-532, PYSEC-2021-730
- github.com/tensorflow/tensorflow/security/advisories/GHSA-8rm6-75mf-7r7r
- nvd.nist.gov/vuln/detail/CVE-2021-29604
- github.com/tensorflow/tensorflow/commit/5117e0851348065ed59c991562c0ec80d9193db2
- github.com/pypa/advisory-database/tree/main/vulns/tensorflow-cpu/PYSEC-2021-532.yaml
- github.com/pypa/advisory-database/tree/main/vulns/tensorflow-gpu/PYSEC-2021-730.yaml
- github.com/pypa/advisory-database/tree/main/vulns/tensorflow/PYSEC-2021-241.yaml
- github.com/tensorflow/tensorflow
- github.com/tensorflow/tensorflow/blob/1a8e885b864c818198a5b2c0cbbeca5a1e833bc8/tensorflow/lite/kernels/hashtable_lookup.cc#L114-L115